Add Safe Area to Drawer (Fixes Issue #508)#510
Open
Roaring30s wants to merge 2 commits intolivepeer:mainfrom
Open
Add Safe Area to Drawer (Fixes Issue #508)#510Roaring30s wants to merge 2 commits intolivepeer:mainfrom
Roaring30s wants to merge 2 commits intolivepeer:mainfrom
Conversation
|
@Roaring30s is attempting to deploy a commit to the Livepeer Foundation Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Drawer Safe Area on Android
Summary
Fixed the main Drawer component to respect Android safe area insets, preventing footer content (including "What's New" link) from being cut off by the navigation bar.
Fixes #508
Changes Made
100vhto100dvh(dynamic viewport height) to account for browser UI changesenv(safe-area-inset-top)to top padding to respect status bar/notch areaenv(safe-area-inset-bottom)to bottom padding to prevent content from being obscured by navigation barTechnical Details
calc()to combine design tokens with safe area insets100dvhfor dynamic viewport height that adjusts with browser UIFiles Changed
components/Drawer/index.tsxTesting
Tested on Android devices to verify footer content is fully visible and not cut off by the navigation bar.
Before
After